Skip to content

Blunt.Behaviour shows missing callbacks in error message #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thetamind wants to merge 1 commit into
base: reorg
Choose a base branch
from
Open

Blunt.Behaviour shows missing callbacks in error message #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions apps/blunt_data/lib/blunt/behaviour.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,16 @@ defmodule Blunt.Behaviour do

case Code.ensure_compiled(module) do
{:module, module} ->
if has_all_callbacks?(module, behaviour_module),
do: {:ok, module},
else: {:error, error}
case has_all_callbacks?(module, behaviour_module) do
true ->
{:ok, module}

{:error, missing_callbacks} ->
missing = inspect(missing_callbacks)
actual = module.__info__(:functions) |> inspect()
error = "#{error}\nExpected: #{missing}\nGot: #{actual}"
{:error, error}
end

_ ->
{:error, error}
Expand Down Expand Up @@ -45,14 +52,16 @@ defmodule Blunt.Behaviour do
callbacks = behaviour_module.behaviour_info(:callbacks)
optional_callbacks = behaviour_module.behaviour_info(:optional_callbacks) |> Keyword.keys()

callbacks
|> Enum.reject(fn {name, _arity} -> Enum.member?(optional_callbacks, name) end)
|> Enum.all?(fn {name, arity} ->
# module.__info__(:functions)
# |> IO.inspect(label: "#{inspect(module)} ~/code/personal/blunt/apps/blunt_data/lib/blunt/behaviour.ex:52")
missing_callbacks =
callbacks
|> Enum.reject(fn {name, _arity} -> Enum.member?(optional_callbacks, name) end)
|> Enum.reject(fn {name, arity} ->
function_exported?(module, name, arity)
end)

function_exported?(module, name, arity)
# |> IO.inspect(label: "#{inspect(module)} #{inspect(name)}/#{inspect(arity)}")
end)
case missing_callbacks do
[] -> true
missing_callbacks -> {:error, missing_callbacks}
end
end
end