Add ActionMailer support#34
Open
xeviknal wants to merge 1 commit intobmista:masterfrom
Open
Conversation
xeviknal
force-pushed
the
action-mailer
branch
from
9d5457e to
dd78c1f
Compare
bmista
reviewed
Feb 5, 2018
| tracer: tracer, | ||
| active_span: active_span, | ||
| start_time: start, | ||
| message_id: payload.fetch(:message_id), |
Owner
There was a problem hiding this comment.
what about other information like data, bcc etc which is supplied within the event? I assume that was the only information necessary for your use case?
bmista
reviewed
Feb 5, 2018
| 'component' => 'ActionMailer', | ||
| 'span.kind' => 'client', | ||
| 'mail.message_id' => fields.fetch(:message_id), | ||
| 'mail.to' => fields.fetch(:to), |
Owner
There was a problem hiding this comment.
to, and from are arrays. From OpenTracing specification
The tag value, which must be either a string, a boolean value, or a numeric type
Probably what needs to happen is to format it into a single string value
bmista
reviewed
Feb 5, 2018
| it "sets standard OT tags" do | ||
| [ | ||
| ['component', 'ActionMailer'], | ||
| ['span.kind', 'client'] |
Owner
There was a problem hiding this comment.
I'm missing a test for non-standard OT tags
Owner
|
btw @xeviknal hello, and thanks for your first contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for ActionMailer. It adds an span with the mailer's name.