Full request tracing#37
Open
achandras wants to merge 17 commits intobmista:masterfrom
Open
Conversation
added 17 commits
October 16, 2018 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR has instrumentation for some new notifications, as well as an attempt to group spans together by request id when possible.
This is achieved by storing notifications until the
process_actionnotification fires, at which point the request is probably done.There are still some rough edges, like perhaps a new parent span can be constructed using the info from
process_actionrather than using that as the parent span, and in the futurerender_partialcan be nested inrender_templatespans.Please let me know any feedback or improvements!