Skip to content

Fix rate limiter tests #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BifrostTitan merged 2 commits into from
May 29, 2025
Merged

Fix rate limiter tests #496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fcefcd
Fix obsolete tests
mocolicious May 27, 2025
f57f16e
use await
mocolicious May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 27 additions & 28 deletions test/Solnet.Rpc.Test/SolanaRpcRateLimitingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,39 +12,39 @@ namespace Solnet.Rpc.Test
public class SolanaRpcRateLimitingTests
{
[TestMethod]
public void TestMaxSpeed_NoLimits()
public async Task TestMaxSpeed_NoLimits()
{
// allow unlimited fires instantly
var limit = RateLimiter.Create();
Assert.IsTrue(limit.CanFire());
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
}

[TestMethod]
public void TestMaxSpeed_WithinLimits()
public async Task TestMaxSpeed_WithinLimits()
{
// allow unlimited fires instantly
var limit = RateLimiter.Create().AllowHits(100).PerSeconds(10);
Assert.IsTrue(limit.CanFire());
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
limit.Fire();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
await limit.WaitFireAsync();
}

[TestMethod]
public void TestTwoHitsPerSecond()
public async Task TestTwoHitsPerSecond()
{
// allow 2 hits per second
var timeCheck = DateTime.UtcNow;
Expand All @@ -53,19 +53,19 @@ public void TestTwoHitsPerSecond()
Console.WriteLine(limit);
Assert.IsTrue(limit.CanFire());
Console.WriteLine(limit);
limit.Fire();
await limit.WaitFireAsync();
Console.WriteLine(limit);
limit.Fire();
await limit.WaitFireAsync();
Console.WriteLine(limit);
limit.Fire();
await limit.WaitFireAsync();
Console.WriteLine(limit);
limit.Fire();
await limit.WaitFireAsync();
Console.WriteLine(limit);
limit.Fire();
await limit.WaitFireAsync();
Console.WriteLine(limit);
limit.Fire();
await limit.WaitFireAsync();
Console.WriteLine(limit);
limit.Fire();
await limit.WaitFireAsync();
Console.WriteLine(limit);

// observe why this may break the build
Expand All @@ -74,8 +74,7 @@ public void TestTwoHitsPerSecond()
Console.WriteLine($"TimeCheck diff {finalTimeCheck.Subtract(twoSecondsLater).TotalMilliseconds}ms");
Assert.IsTrue(finalTimeCheck.Subtract(timeCheck).TotalMilliseconds > 2000, $"ExecTime diff {finalTimeCheck.Subtract(timeCheck).TotalMilliseconds}ms");
}



[TestMethod]
public async Task TestMaxSpeed_NoLimits_Async()
{
Expand Down
Loading