Skip to content

Improvements on corner milling #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Salamandar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvements on corner milling #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e3fdad
Do not add milling holes where they are not needed
Salamandar Oct 11, 2019
58aad53
Only mill what's necessary diagonally
Salamandar Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lasercut.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ module fingers(angle, start_up, fingers, thickness, range_min, range_max, t_x, t

module fingers_mill(angle, start_up, fingers, thickness, range_min, range_max, t_x, t_y, bit=6.35/2)
{

delta = bit * (1-sin(45)) / 2;
// The tweaks to y translate([0, -thickness,0]) ... thickness*2 rather than *1
// Are to avoid edge cases and make the dxf export better.
// All fun
Expand All @@ -388,16 +388,18 @@ module fingers_mill(angle, start_up, fingers, thickness, range_min, range_max, t
{
translate([((range_max-range_min)/fingers)*p,0,0])
{
translate([(range_max-range_min)/(fingers*2) + bit/2,thickness,0]) cylinder(h=thickness*4, d=bit, center=true );
translate([2*(range_max-range_min)/(fingers*2) - bit/2,thickness,0]) cylinder(h=thickness*4, d=bit, center=true );
translate([(range_max-range_min)/(fingers*2) + bit/2-delta,thickness+bit/2 - delta,0]) cylinder(h=thickness*4, d=bit, center=true , $fn=20);
if (p != fingers-1)
translate([2*(range_max-range_min)/(fingers*2) - bit/2+delta,thickness+bit/2-delta,0]) cylinder(h=thickness*4, d=bit, center=true , $fn=20);
}
}
else
{
translate([((range_max-range_min)/fingers)*p,0,0])
{
translate([bit/2,thickness,0]) cylinder(h=thickness*4, d=bit, center=true );
translate([(range_max-range_min)/(fingers*2) - bit/2,thickness,0]) cylinder(h=thickness*4, d=bit, center=true );
if (p != 0)
translate([bit/2-delta,thickness+bit/2-delta,0]) cylinder(h=thickness*4, d=bit, center=true , $fn=20);
translate([(range_max-range_min)/(fingers*2) - bit/2+delta,thickness+bit/2-delta,0]) cylinder(h=thickness*4, d=bit, center=true , $fn=20);
}
}
}
Expand Down