Skip to content

feat(rpc) get finalized header bsc fix#95

Open
MatusKysel wants to merge 8 commits intorebase-v1.10.2-bnbfrom
feat/eth_getFinalizedHeader-bsc-fix
Open

feat(rpc) get finalized header bsc fix#95
MatusKysel wants to merge 8 commits intorebase-v1.10.2-bnbfrom
feat/eth_getFinalizedHeader-bsc-fix

Conversation

@MatusKysel
Copy link
Contributor

No description provided.

@MatusKysel MatusKysel requested a review from joey0612 as a code owner February 19, 2026 13:20
@github-actions
Copy link
Contributor

Your PR title doesn't follow the Conventional Commit guidelines.

Example of valid titles:

  • feat: add new user login
  • fix: correct button size
  • docs: update README

Usage:

  • feat: Introduces a new feature
  • fix: Patches a bug
  • chore: General maintenance tasks or updates
  • test: Adding new tests or modifying existing tests
  • bench: Adding new benchmarks or modifying existing benchmarks
  • perf: Performance improvements
  • refactor: Changes to improve code structure
  • docs: Documentation updates
  • ci: Changes to CI/CD configurations
  • revert: Reverts a previously merged PR
  • deps: Updates dependencies

Breaking Changes

Breaking changes are noted by using an exclamation mark. For example:

  • feat!: changed the API
  • chore(node)!: Removed unused public function

Help

For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/

@MatusKysel MatusKysel force-pushed the feat/eth_getFinalizedHeader-bsc-fix branch from 3ca0a64 to 17f682f Compare February 20, 2026 13:13
- Import EthApiError from reth_rpc_eth_types instead of crate root
- Add BlockReaderIdExt to reth_storage_api imports for sealed_header_by_id
- Fix closure return type mismatch in resolved_validators_threshold
@constwz constwz force-pushed the feat/eth_getFinalizedHeader-bsc-fix branch from f5be26f to 18da97c Compare March 1, 2026 04:08
@constwz constwz force-pushed the feat/eth_getFinalizedHeader-bsc-fix branch from 18da97c to 32440cb Compare March 1, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants