Propagate Apple Team ID through to AppClip target#83
Merged
nathan-ahn merged 1 commit intobndkt:mainfrom Feb 13, 2026
Merged
Conversation
If `ios.appleTeamId` is defined in app.json / app.config.js, it is now propagated to the Clip target too. Previously the developer would need to manually set the Signing Team in Xcode > Signing & Capabilities.
Contributor
Author
|
Hello again @nathan-ahn! What do you think of this small developer experience improvement for the package? |
There was a problem hiding this comment.
Pull request overview
This PR adds support for automatically propagating the Apple Team ID from the Expo config (ios.appleTeamId in app.json/app.config.js) to the App Clip target's Xcode build settings. Previously, developers had to manually configure the Signing Team in Xcode > Signing & Capabilities for the App Clip target.
Changes:
- Modified
addXCConfigurationListto accept an optionalappleTeamIdparameter and conditionally addDEVELOPMENT_TEAMto build settings - Updated
withXcodeto passconfig.ios?.appleTeamIdfrom the Expo config to the App Clip configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/src/xcode/addXCConfigurationList.ts | Added optional appleTeamId parameter and conditionally sets DEVELOPMENT_TEAM in build settings |
| plugin/src/withXcode.ts | Passes config.ios?.appleTeamId from Expo config to addXCConfigurationList |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@trentrand Looks great! Thanks for putting this together :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
ios.appleTeamIdis defined in app.json / app.config.js, it is now propagated to the Clip target too. Previously the developer would need to manually set the Signing Team in Xcode > Signing & Capabilities.