fix(jenkins): respect context when fetching builds#277
Open
tlkamp wants to merge 1 commit intobndr:masterfrom
Open
fix(jenkins): respect context when fetching builds#277tlkamp wants to merge 1 commit intobndr:masterfrom
tlkamp wants to merge 1 commit intobndr:masterfrom
Conversation
The GetBuildFromQueueID function previously polled forever and did not monitor the context for cancellation. This caused infinite blocking problems when Jenkins was "preparing for shutdown"/"quieting down". The contexts can now be cancelled so that the function no longer blocks forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GetBuildFromQueueID function previously polled forever and did not monitor the context for
cancellation. This caused infinite blocking problems when Jenkins was "preparing for
shutdown"/"quieting down". The contexts can now be cancelled so that the function no longer blocks
forever.