fix: implement trampoline pattern for GLib callbacks to prevent purego slot exhaustion#170
Merged
fix: implement trampoline pattern for GLib callbacks to prevent purego slot exhaustion#170
Conversation
📝 WalkthroughWalkthroughGo toolchain in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GLib source functions previously allocated a new purego callback slot for every invocation. purego has a hard limit of 2000 slots, so long-running programs that schedule many one-shot idle/timeout callbacks would exhaust the pool and panic.
Solution
The trampoline uses a single purego callback that dispatches through a Go-side map keyed by an opaque ID passed as GLib's user_data pointer. All IdleAdd/TimeoutAdd calls share ONE purego slot regardless of how many are outstanding.
Changes
Impact
This fixes the issue where dumber would close unexpectedly after running for extended periods due to callback slot exhaustion.
Summary by CodeRabbit