Remove HijriSimulatedMecca / islamic-rgsa #597
Merged
+51
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec doesn't have it anymore Change-Id: I6a6a6964444bf7d9c9c44a0a25d5db674f97ab1e
nekevss
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec doesn't have it anymore.
We use AnyCalendarKind parsing code so we still parse it, we just turn it into Iso.
I don't quite know the best way to handle this for temporal_rs: Calendar::new is infallible, but it's mostly internally used in parsing, and we accept AnyCalendarKinds in our public API.
I think in the long run we should switch to
try_newand in the IXDTF parsing case have a fallback to Iso.