Skip to content

Supporting Unpublished Places #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daireb wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Supporting Unpublished Places #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2971416
added dummy datastore functionality to allow editing for non-publishe…
daireb Sep 27, 2025
075326e
fixed accidental formatting change
daireb Sep 27, 2025
e12a057
added comment explaining DummyDatastore
daireb Sep 27, 2025
57d19f1
set messagingservice publishasync to happen in the background to prev…
daireb Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
{
"name": "@boatbomber/sheetvalues",
"version": "3.0.2",
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/boatbomber/SheetValues.git"
},
"contributors": [
"boatbomber"
],
"bugs": {
"url": "https://github.com/boatbomber/SheetValues/issues"
}
"name": "@boatbomber/sheetvalues",
"version": "3.0.3",
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/boatbomber/SheetValues.git"
},
"contributors": [
"boatbomber",
"daireb"
],
"bugs": {
"url": "https://github.com/boatbomber/SheetValues/issues"
}
}
28 changes: 23 additions & 5 deletions src/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,16 @@ local function DictEquals(a, b)
return true
end

local DummyDatastore = { -- Dummy Datastore object to fall back to if DataStoreService fails
GetAsync = function()
return nil
end,
SetAsync = function() end,
UpdateAsync = function(_, callback)
return callback(nil)
end,
}

local SheetValues = {}

function SheetValues.new(SpreadId: string, SheetId: string?)
Expand All @@ -270,6 +280,15 @@ function SheetValues.new(SpreadId: string, SheetId: string?)

local ChangedEvent = Instance.new("BindableEvent")

local dsSuccess, dsReturn = pcall(DatastoreService.GetDataStore, DatastoreService, GUID, "SheetValues")
local DataStore
if dsSuccess then
DataStore = dsReturn
else
DataStore = DummyDatastore
warn("SheetValues: Failed to get DataStore:", dsReturn)
end

local SheetManager = {
Changed = ChangedEvent.Event,

Expand All @@ -278,7 +297,7 @@ function SheetValues.new(SpreadId: string, SheetId: string?)
Values = {},

_ValueChangeEvents = {},
_DataStore = DatastoreService:GetDataStore(GUID, "SheetValues"),
_DataStore = DataStore,
_MessageListener = nil,
_Alive = true,
}
Expand Down Expand Up @@ -385,13 +404,12 @@ function SheetValues.new(SpreadId: string, SheetId: string?)

-- Send these values to all other servers
if self.LastSource == "Google API" then
local msgSuccess, msgResponse = pcall(
task.spawn(pcall,
MessagingService.PublishAsync,
MessagingService,
GUID,
#json < 1000 and json or "TriggerStore"
)
--if not msgSuccess then warn(msgResponse) end
)
end

return true, "Values updated"
Expand Down Expand Up @@ -469,7 +487,7 @@ function SheetValues.new(SpreadId: string, SheetId: string?)
table.clear(self)
end

pcall(function()
task.spawn(pcall, function()
SheetManager._MessageListener = MessagingService:SubscribeAsync(GUID, function(Msg)
local msgTimestamp = math.floor(Msg.Sent)
if msgTimestamp <= SheetManager.LastUpdated then
Expand Down