Remove removal of :tags= - doesn't work unless I remove this#14
Open
robinbowes wants to merge 1 commit intobobtfish:masterfrom
Open
Remove removal of :tags= - doesn't work unless I remove this#14robinbowes wants to merge 1 commit intobobtfish:masterfrom
robinbowes wants to merge 1 commit intobobtfish:masterfrom
Conversation
Owner
|
What version of puppet are you using for your tests here? The problem/issue that this code is solving is that mk_resource_methods injects a tags= method, which we don't want (as we want the tags= method inherited from the parent class) |
Contributor
Author
|
This is using 3.6.2 on OSX: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what this line of code does, or is supposed to do, but unless I remove it the aws_iam_role resource type doesn't work: