Open
Conversation
Collaborator
|
I think that we should remove events from this calendar in all othere calendars as well. Cause clean and sync again takes a while for large amount of events |
L0ndra
reviewed
Jan 7, 2025
| return | ||
| } | ||
| var count int | ||
| err = db.QueryRow("SELECT COUNT(*) FROM calendars WHERE calendar_id = ?", calendarID).Scan(&count) |
Collaborator
There was a problem hiding this comment.
maybe move this check before confirmation?
Contributor
|
I believe that we can just ask the user for the events deletion as an additional question |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support to delete a calendar that's no longer needed. Note this does not remove all the associated blocked events from all calendars by design. That can be executed through clean, if required