feat: implement method to fetch token using the client credentials grant#333
Merged
oliver006 merged 3 commits intobold-commerce:masterfrom Dec 11, 2025
Merged
feat: implement method to fetch token using the client credentials grant#333oliver006 merged 3 commits intobold-commerce:masterfrom
oliver006 merged 3 commits intobold-commerce:masterfrom
Conversation
oliver006
reviewed
Dec 4, 2025
|
|
||
| client := app.Client | ||
| if client == nil { | ||
| client = MustNewClient(app, shopName, "") |
Collaborator
There was a problem hiding this comment.
can you add a test that includes covering this line please?
Collaborator
There was a problem hiding this comment.
same for line 68
look at TestAppGetAccessTokenError() which does it for GetAccessToken()
Author
There was a problem hiding this comment.
Thanks for pointing that out @oliver006. I've just pushed a new commit with the mentioned change.
Author
There was a problem hiding this comment.
Hi @oliver006, can this PR be merged or is there something else I have missed and you'd like to me add?
oliver006
approved these changes
Dec 11, 2025
Collaborator
oliver006
left a comment
oliver006
left a comment
There was a problem hiding this comment.
Looks good - sorry about the delay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.