Skip to content

♻️ 💥 Integrate translation behavior #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

♻️ 💥 Integrate translation behavior #3561

wants to merge 7 commits into from

Conversation

@macintoshplus
Copy link
Contributor

@macintoshplus macintoshplus commented Mar 13, 2025 •
edited
Loading

See #3551

@macintoshplus macintoshplus added the dependencies Pull requests that update a dependency file label Mar 13, 2025
@macintoshplus macintoshplus mentioned this pull request Mar 13, 2025
Open
19 tasks
bobvandevijver
bobvandevijver requested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change, needs a note in the upgrade docs.

@macintoshplus macintoshplus changed the title ♻️ Integrate translation behavior ♻️ 💥 Integrate translation behavior Mar 14, 2025
bobvandevijver
bobvandevijver requested changes Jul 20, 2025
View reviewed changes
Copy link
Member

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to check the new classes but I'm out of time for today, but here are already some comments that need to adressed anyways

config/services.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the services.yaml will need to have a yaml migration defined as well.

macintoshplus and others added 2 commits July 22, 2025 18:09
@macintoshplus @bobvandevijver
Apply suggestions from code review
af3417c 
Co-authored-by: Bob van de Vijver <bobvandevijver@users.noreply.github.com>
@macintoshplus
add yaml migration and update UPGRADING file
c2bc45c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobvandevijver bobvandevijver bobvandevijver requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@macintoshplus macintoshplus

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@macintoshplus @bobvandevijver