-
Notifications
You must be signed in to change notification settings - Fork 2
Update CLAUDE.md: fix CI section, test flags, add memory file note #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+10
−4
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -30,22 +30,24 @@ There is no Makefile — building is done exclusively through Docker. | |||||
|
|
||||||
| ```bash | ||||||
| # Run all tests (from docker/card/) | ||||||
| cd docker/card && go test ./... | ||||||
| cd docker/card && go test -race -count=1 ./... | ||||||
|
|
||||||
| # Run specific test packages | ||||||
| go test ./crypto/ # AES-CMAC and AES decrypt tests | ||||||
| go test ./db/ # Schema migration, settings CRUD, card operations (uses in-memory SQLite) | ||||||
| go test ./web/ # HTTP handler tests (auth, balance, path traversal) | ||||||
| ``` | ||||||
|
|
||||||
| Tests require CGo (for `go-sqlite3`). CI runs tests automatically via GitHub Actions on push/PR to main. | ||||||
| Tests require CGo (for `go-sqlite3`) and `HOST_DOMAIN` env var (db_init panics without it; test helpers set it automatically). CI runs tests automatically via GitHub Actions on push/PR to main. | ||||||
|
|
||||||
| ## CI | ||||||
|
|
||||||
| GitHub Actions workflow (`.github/workflows/ci.yml`) runs on push/PR to `main`: | ||||||
| - `go vet ./...` | ||||||
| - `go build` | ||||||
| - `go test ./...` | ||||||
| - `go test -race -count=1 ./...` | ||||||
| - `govulncheck ./...` | ||||||
| - Docker image builds for both `card` and `webproxy` | ||||||
|
|
||||||
| Uses Go 1.25.7 with CGo enabled for sqlite3. | ||||||
|
|
||||||
|
|
@@ -116,4 +118,8 @@ Schema version managed by idempotent `update_schema_*` functions in `db_create.g | |||||
| - `aead/cmac` — AES-CMAC for Bolt Card auth | ||||||
| - `go-ini/ini` — Phoenix config file parsing | ||||||
| - `skip2/go-qrcode` — QR code generation | ||||||
| - `golang.org/x/crypto` — bcrypt password hashing | ||||||
| - `golang.org/x/crypto` — bcrypt password hashing | ||||||
|
|
||||||
| ## Memory File | ||||||
|
|
||||||
| After completing a set of changes, update the persistent memory file at `~/.claude/projects/-home-user-boltcard-hub/memory/MEMORY.md` with any new patterns, conventions, or project facts discovered during the session. Keep it concise and organized by topic. This helps maintain context across conversations. | ||||||
|
||||||
| After completing a set of changes, update the persistent memory file at `~/.claude/projects/-home-user-boltcard-hub/memory/MEMORY.md` with any new patterns, conventions, or project facts discovered during the session. Keep it concise and organized by topic. This helps maintain context across conversations. | |
| After completing a set of changes, update the persistent memory file associated with this repository (for example, a `MEMORY.md` file under `.claude/memory/` in the repo root) with any new patterns, conventions, or project facts discovered during the session. Keep it concise and organized by topic. This helps maintain context across conversations. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI workflow doesn’t run
govulncheck ./...directly; it runs it viago run golang.org/x/vuln/cmd/govulncheck@latest ./...(so it works without a preinstalled binary). To keep this section accurate and copy/pasteable, update the documented command or explicitly note thatgovulncheckmust be installed if using the shorter form.