-
Notifications
You must be signed in to change notification settings - Fork 32
Version upgrade & Associations & Table Naming #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kurisutofu
wants to merge
53
commits into
bonaval:master
Choose a base branch
from
kurisutofu:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurisutofu
commented
May 30, 2019
- Upgraded to latest version for lodash, mocha, sequelize, sqlite3
- Added possibility to specify suffix for historical tables instead of static "Histories"
- Added possibility to have associations to the origin models
Greenkeeper initial
Added the 'modelSuffix' option to enable custom name to be appended to Model and Table
Added ModelSuffix
Remove wrong explanation
Fixed Read Me
Remove wrong text again.
Fixed Read Me
Added modelSuffix to ts file
Implementation of Association but not yet working.
+ All tests passing + Updated Lodash + Updated Mocha
Ready for release
Adding Travis
+ Reverted to BeforeInsert instead of BeforeBulkInsert + Updated logic to sync with historical + Added origin model as a property of the historical model
Bug fix + renaming
Update names
Names update again
Renaming to temporal
Fixed ReadMe
+ Updated the association copied from the original model to not cascade the update/delete actions.
Association onDelete/onUpdate actions
+ Removed associations from historical model to avoid error if table in different DB
Removing associations
Added the ability
Added the ability to disable transaction on history tables (in case used in a separate DB)
Added AfterBulk hooks
Hey @kurisutofu Thx for the contribution, I've managed to update the dependencies in another PR. Do you mind splitting your features in individual, new PR? Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.