Conversation
|
Important Review skippedToo many files! This PR contains 298 files, which is 148 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (298)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks a significant strategic shift for the project, moving from a multi-platform tool to a focused CLI-only experience. The changes encompass a complete rebranding to 'BWEN Code' and the removal of web and IDE-specific integrations, streamlining the application for terminal environments. Concurrently, new CLI-centric features, such as an interactive file tree and intelligent image paste handling, have been introduced to enhance the command-line user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d0e4a07ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "workspaces": [ | ||
| "packages/*" | ||
| "packages/cli", | ||
| "packages/core", | ||
| "packages/test-utils", | ||
| "packages/web-templates", |
There was a problem hiding this comment.
The root workspace list now excludes packages/sdk-typescript and packages/vscode-ide-companion, but repo-level scripts still rely on both packages. In this revision, npm run build --workspace=packages/sdk-typescript and node scripts/build_vscode_companion.js both fail with npm error No workspaces found, so build:vscode, build:all, and the SDK root workflows no longer work from a clean checkout.
Useful? React with 👍 / 👎.
| "bwen-code-sidebar": [ | ||
| { | ||
| "type": "webview", | ||
| "id": "qwen-code.chatView.sidebar", | ||
| "name": "Qwen Code", | ||
| "id": "bwen-code.chatView.sidebar", |
There was a problem hiding this comment.
These new bwen-code.*/bwen.diff.* manifest IDs are not registered anywhere in the extension implementation. src/constants/viewIds.ts:16-17, src/commands/index.ts:18-25, and src/extension.ts:226-370 still use the old qwen-* strings, so the sidebar provider and command-palette entries declared here will stop resolving once the renamed extension is packaged.
Useful? React with 👍 / 👎.
| "name": "bwen-code-vscode-ide-companion", | ||
| "displayName": "BWEN Code Companion", | ||
| "description": "Enable BWEN Code with direct access to your VS Code workspace.", | ||
| "version": "0.12.3", | ||
| "publisher": "qwenlm", | ||
| "publisher": "bonsai", |
There was a problem hiding this comment.
Changing the manifest to bonsai.bwen-code-vscode-ide-companion without updating the hard-coded marketplace identifier leaves the in-product install/update path pointing at the old extension. packages/core/src/ide/ide-installer.ts:126 and packages/vscode-ide-companion/src/extension.ts:24/:297-300 still request qwenlm.qwen-code-vscode-ide-companion, so users clicking “Update to latest version” or installing from the CLI will fetch the wrong listing.
Useful? React with 👍 / 👎.
| # Start | ||
| npm start | ||
| # or if linked globally | ||
| bwen |
There was a problem hiding this comment.
bwen binary before documenting it
The getting-started instructions here now tell users to npm link --workspace=@bwen-code/bwen-code and then run bwen, but the root package still only defines qwen in package.json:74-76. Following the updated path from a fresh checkout therefore ends with bwen: command not found instead of starting the CLI.
Useful? React with 👍 / 👎.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant rebranding from qwen-code to bwen-code and refocuses the project to be CLI-only. It also adds a new file tree UI to the CLI and support for pasting image paths as attachments. My review has identified a few issues, including an inconsistency in the root package.json that still references removed web packages, a typo in the README's installation instructions, and the presence of BOM characters in many files. I've also suggested an improvement to the new file tree component to make its dotfile filtering less restrictive.
| "workspaces": [ | ||
| "packages/*" | ||
| "packages/cli", | ||
| "packages/core", | ||
| "packages/test-utils", | ||
| "packages/web-templates", | ||
| "packages/webui" | ||
| ], |
There was a problem hiding this comment.
The workspaces configuration includes packages/webui and packages/web-templates, but the BWEN-README.md file states that Web UI components and web templates have been removed as part of the project's focus on being CLI-only. This inconsistency can cause confusion and may lead to issues with dependency management or build processes if those directories are indeed removed. Please update the workspaces to reflect the actual project structure.
"packages/cli",
"packages/core",
"packages/test-utils"
],| ```bash | ||
| # Clone the repository | ||
| git clone https://github.com/bonsai/bwen-code.git | ||
| cd bwencode |
There was a problem hiding this comment.
There's a typo in the installation instructions. The command cd bwencode should be cd bwen-code to match the repository name cloned in the previous step. This will cause the setup to fail for users following the guide.
| cd bwencode | |
| cd bwen-code |
| @@ -1,4 +1,4 @@ | |||
| /** | |||
| /** | |||
There was a problem hiding this comment.
This file, along with many others in this pull request, starts with a UTF-8 Byte Order Mark (BOM) character (\uFEFF). While many modern tools handle this correctly, it's not recommended for UTF-8 files and can cause issues with some environments, linters, or concatenation scripts. It's best practice to save these files as "UTF-8 without BOM" to ensure maximum compatibility and prevent potential issues. Please remove the BOM from all affected files.
| if (entry.name.startsWith('.') && !entry.name.match(/^\.[a-z]+rc$/)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
The logic for filtering hidden files in the file tree is a bit too restrictive. The current implementation at line 120 skips any file starting with a dot (.) unless it matches the regex ^\.[a-z]+rc$. This means important configuration files like .gitignore, .prettierrc, or .npmrc will be hidden from the user. This could make it harder for the user to understand the project's full configuration.
I suggest expanding the condition to explicitly allow common dotfiles like .gitignore.
| if (entry.name.startsWith('.') && !entry.name.match(/^\.[a-z]+rc$/)) { | |
| continue; | |
| } | |
| if (entry.name.startsWith('.') && entry.name !== '.gitignore' && !entry.name.match(/^\.[a-z]+rc$/)) { | |
| continue; | |
| } |
1 participant
This PR includes various updates and improvements to the codebase.