Ability to pass custom state in authentication URL#2
Open
sarmad90 wants to merge 2 commits intobonusly:masterfrom
Open
Ability to pass custom state in authentication URL#2sarmad90 wants to merge 2 commits intobonusly:masterfrom
sarmad90 wants to merge 2 commits intobonusly:masterfrom
Conversation
Pass custom state to BambooId::Urls::AuthUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was required for our project to pass in a custom
stateto the authentication URL. So we have added the ability to do so. Plus made some minor corrections in the readme.md. Passing the customstateis optional and the existing behavior will be used if no customstateis passed.