Skip to content

test: add test suites for 8 untested analyzers#222

Merged
himerus merged 2 commits intodevfrom
feature/test-add-test-suites-for-8-untested
Mar 26, 2026
Merged

test: add test suites for 8 untested analyzers#222
himerus merged 2 commits intodevfrom
feature/test-add-test-suites-for-8-untested

Conversation

@himerus
Copy link
Copy Markdown
Contributor

@himerus himerus commented Mar 26, 2026

Summary

8 analyzer files in packages/core/src/handlers/analyzers/ have zero test coverage:

  1. api-surface.ts (91 lines)
  2. type-coverage.ts (84 lines)
  3. event-architecture.ts
  4. css-architecture.ts
  5. mixin-resolver.ts (440 lines — LARGE, complex mixin resolution logic)
  6. slot-architecture.ts (253 lines)
  7. naming-consistency.ts (380 lines — LARGE, library-wide pattern scoring)
  8. source-accessibility.ts (368 lines — LARGE, has skipIf tests for real libs but no unit tests)

Create test files in tests...


Created automatically by Automaker

himerus and others added 2 commits March 26, 2026 18:21
- mixin-resolver: chain resolution, architecture classification, aggregated markers, ResolvedSource structure
- naming-consistency: prefix detection, per-component scoring, confidence levels, normalization
- source-accessibility: PATTERNS export, scanSourceForA11yPatterns, scoreSourceMarkers, isInteractiveComponent, resolveComponentSourceFilePath
- slot-architecture: default/named slot scoring, type constraints, kebab-to-camel coherence, jsdocTags detection
- api-surface: method/attribute/default/description scoring, null cases, normalization
- type-coverage: property/event/method type scoring, bare Event exclusion, single-dimension normalization
- event-architecture: kebab-case validation, typed payload scoring, description scoring
- css-architecture: CSS property/parts documentation, design token naming pattern validation

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix mixin-resolver: LitElement is a framework base class that
  getInheritanceChain() skips entirely — it does not appear in
  unresolved; add a separate test for non-framework superclasses
- Fix source-accessibility: TABINDEX_SOURCE used setAttribute which
  does not match the tabindex\s*[=:] pattern; use property assignment
  form that the regex actually matches

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026

Warning

Rate limit exceeded

@himerus has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 96617511-62c0-4845-a8ad-18587f5ace4d

📥 Commits

Reviewing files that changed from the base of the PR and between 600373c and 19c25c4.

📒 Files selected for processing (8)
  • tests/handlers/analyzers/api-surface.test.ts
  • tests/handlers/analyzers/css-architecture.test.ts
  • tests/handlers/analyzers/event-architecture.test.ts
  • tests/handlers/analyzers/mixin-resolver.test.ts
  • tests/handlers/analyzers/naming-consistency.test.ts
  • tests/handlers/analyzers/slot-architecture.test.ts
  • tests/handlers/analyzers/source-accessibility.test.ts
  • tests/handlers/analyzers/type-coverage.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/test-add-test-suites-for-8-untested

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@himerus himerus merged commit db217f2 into dev Mar 26, 2026
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant