Skip to content

Add flag '--no-allow-vendor-change' for zypper upgrades #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jefetienne wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add flag '--no-allow-vendor-change' for zypper upgrades #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tumbleweed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,12 @@ tumbleweed_uninit()
tumbleweed_install()
{
sudo zypper ref
sudo zypper dup

if [ "$no_allow_vendor_change" == "1" ] ; then
sudo zypper dup --no-allow-vendor-change
Copy link
Owner

@boombatower boombatower Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't no allow vendor change the default in Tumbleweed or was that changed back? I am not sure we want to start adding all zypper flags here. Also with properly set repository priorities one wants to allow vendor change.

Essentially, if I want to do something fancy like tumbleweed switch and zypper dup -d I do those commands separately. I am not sure we want to start supporting a variety of use-cases of zypper.

Copy link
Author

@jefetienne jefetienne Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to have been rolled back on my fresh openSUSE install, but I understand the implication of needing to add multiple zypper flags. I'll leave it up to you if you'd like to accept this PR or not, otherwise I can close it.

else
sudo zypper dup
fi
}

tumbleweed_migrate_check()
Expand Down Expand Up @@ -300,6 +305,8 @@ Options:
--version Print version string and exit
--force Force on operation to occur regardless of checks.
--install Initiate install after command.
--no-allow-vendor-change
Prevent allowing vendor change for upgrades.
-h, --help Display this message and exit

Commands:
Expand All @@ -325,6 +332,7 @@ tumbleweed_handle()
--version) echo "$VERSION" ; exit 0 ; ;;
--force) force=1 ; ;;
--install) install=1 ; ;;
--no-allow-vendor-change) no_allow_vendor_change=1 ; ;;
-h|--help) command="usage" ; ;;
history|init|installed|latest|list|revert|status|target|uninit|update|migrate|unmigrate)
command="$1" ; ;;
Expand Down
2 changes: 1 addition & 1 deletion tumbleweed-completion.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ _tumbleweed_completion()
"${COMP_WORDS[1]}" == "upgrade" ||
"${COMP_WORDS[1]}" == "revert" ) ]] ; then

local flags=("--force" "--install")
local flags=("--force" "--install" "--no-allow-vendor-change")
for word in ${COMP_WORDS[@]:2} ; do
for i in ${!flags[@]} ; do
if [ "${flags[$i]}" == "$word" ] ; then
Expand Down