Skip to content

stack: migrate memory order in consume to acquire #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timblechmann merged 1 commit into from
Feb 7, 2026
Merged

stack: migrate memory order in consume to acquire #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions include/boost/lockfree/detail/freelist.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class alignas( cacheline_bytes ) freelist_stack : Alloc
template < bool Bounded >
T* allocate_impl( void )
{
tagged_node_ptr old_pool = pool_.load( memory_order_consume );
tagged_node_ptr old_pool = pool_.load( memory_order_acquire );

for ( ;; ) {
if ( !old_pool.get_ptr() ) {
Expand Down Expand Up @@ -241,7 +241,7 @@ class alignas( cacheline_bytes ) freelist_stack : Alloc
void deallocate_impl( T* n )
{
void* node = n;
tagged_node_ptr old_pool = pool_.load( memory_order_consume );
tagged_node_ptr old_pool = pool_.load( memory_order_acquire );
freelist_node* new_pool_ptr = reinterpret_cast< freelist_node* >( node );

for ( ;; ) {
Expand Down Expand Up @@ -561,7 +561,7 @@ class fixed_size_freelist : NodeStorage
private:
index_t allocate_impl( void )
{
tagged_index old_pool = pool_.load( memory_order_consume );
tagged_index old_pool = pool_.load( memory_order_acquire );

for ( ;; ) {
index_t index = old_pool.get_index();
Expand All @@ -580,7 +580,7 @@ class fixed_size_freelist : NodeStorage

index_t allocate_impl_unsafe( void )
{
tagged_index old_pool = pool_.load( memory_order_consume );
tagged_index old_pool = pool_.load( memory_order_acquire );

index_t index = old_pool.get_index();
if ( index == null_handle() )
Expand All @@ -607,7 +607,7 @@ class fixed_size_freelist : NodeStorage
void deallocate_impl( index_t index )
{
freelist_node* new_pool_node = reinterpret_cast< freelist_node* >( NodeStorage::nodes() + index );
tagged_index old_pool = pool_.load( memory_order_consume );
tagged_index old_pool = pool_.load( memory_order_acquire );

for ( ;; ) {
tagged_index new_pool( index, old_pool.get_tag() );
Expand All @@ -621,7 +621,7 @@ class fixed_size_freelist : NodeStorage
void deallocate_impl_unsafe( index_t index )
{
freelist_node* new_pool_node = reinterpret_cast< freelist_node* >( NodeStorage::nodes() + index );
tagged_index old_pool = pool_.load( memory_order_consume );
tagged_index old_pool = pool_.load( memory_order_acquire );

tagged_index new_pool( index, old_pool.get_tag() );
new_pool_node->next.set_index( old_pool.get_index() );
Expand Down
6 changes: 3 additions & 3 deletions include/boost/lockfree/stack.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ class stack
template < typename Functor >
bool consume_one( Functor&& f )
{
tagged_node_handle old_tos = tos.load( detail::memory_order_consume );
tagged_node_handle old_tos = tos.load( detail::memory_order_acquire );

for ( ;; ) {
node* old_tos_pointer = pool.get_pointer( old_tos );
Expand Down Expand Up @@ -689,7 +689,7 @@ class stack
size_t consume_all_atomic( Functor&& f )
{
size_t element_count = 0;
tagged_node_handle old_tos = tos.load( detail::memory_order_consume );
tagged_node_handle old_tos = tos.load( detail::memory_order_acquire );

for ( ;; ) {
node* old_tos_pointer = pool.get_pointer( old_tos );
Expand Down Expand Up @@ -736,7 +736,7 @@ class stack
size_t consume_all_atomic_reversed( Functor&& f )
{
size_t element_count = 0;
tagged_node_handle old_tos = tos.load( detail::memory_order_consume );
tagged_node_handle old_tos = tos.load( detail::memory_order_acquire );

for ( ;; ) {
node* old_tos_pointer = pool.get_pointer( old_tos );
Expand Down
Loading