-
Notifications
You must be signed in to change notification settings - Fork 43
Implements connect as a FSM and fixes cancellation #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This is an early prototype yet. I've started implementing #319 and it was getting too big and messy around |
This should fix the last race conditions on cancellation and add some coverage. |
Hi Ruben, thanks. This is something I forgot to ask you before: can you please rebase on top of |
I think this one is actually good - it's just ultra segmented in terms of commits, but they're all part of the PR. I always do squash merging when merging, so these won't appear in history - just a big commit replacing them. I did something wrong in the cancel_after PR which I think I've solved now. |
(looks like I commited once per test and wrote about 20 tests, so... :)) |
Implements redis_stream::async_connect as a FSM
Adds per-operation cancellation handling code
Adds tests