Skip to content

Fix gcc version check for diagnostic pop to match diagnostic push #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdimov merged 2 commits into from
Jan 22, 2026
Merged

Fix gcc version check for diagnostic pop to match diagnostic push #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b38910
Fix gcc version check for diagnostic pop to match diagnostic push.
Lastique Jan 22, 2026
16da203
Fix a typo in a comment.
Lastique Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/uuid/detail/cstring.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace detail {
// memcpy

// Note: The function below is a template to prevent an early check whether the function body can ever be evaluated in the context of a constant expression.
// It can't, and that causes compilation errors with clang. The function must still be marked as constexpr to be able to call them in other
// It can't, and that causes compilation errors with clang. The function must still be marked as constexpr to be able to call it in other
// functions that are constexpr, even if such calls are never evaluated in a constant expression. Otherwise, gcc 5 through 8 gets upset.

template< typename = void >
Expand Down
2 changes: 1 addition & 1 deletion include/boost/uuid/detail/simd_vector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ union simd_vector
return *reinterpret_cast< const vector_type* >(bytes);
}

#if defined(BOOST_GCC) && (BOOST_GCC >= 40800)
#if defined(BOOST_GCC) && (BOOST_GCC >= 40600)
#pragma GCC diagnostic pop
#endif
};
Expand Down