libvirt: Add QEMU firmware interop JSON descriptor support #172
Conversation
|
Still testing this one out |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for QEMU's firmware interop specification, replacing the manual, hardcoded firmware path detection. This is a great improvement for portability and correctness, especially on distributions like Debian/Ubuntu. The addition of the print-firmware debug command is also a useful tool for diagnostics. The changes are well-structured. I've provided a couple of suggestions to improve maintainability and to fully align with the QEMU specification.
cgwalters
force-pushed
the
handle-debian-ovmf
branch
from
144fc5e to
b5c82fb
Compare
Parse the QEMU firmware interop specification JSON descriptors to find firmware instead of doing it manually. This fixes OVMF firmware detection on Debian/Ubuntu derivatives. Add a hidden `bcvk libvirt print-firmware` which is a cheap way to test our parser. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
handle-debian-ovmf
branch
from
b5c82fb to
cddf424
Compare
|
OK, this one is now tested in bootc-dev/bootc#1809 - see https://github.com/bootc-dev/bootc/pull/1809/changes#diff-9f49bfa62661bbb5dd03467fa22ac2c966075ded724a545a55d9b7852ae1a849R79 In this I ran into #145 again which added some time. |
2 participants
Parse the QEMU firmware interop specification JSON descriptors to find firmware instead of doing it manually. This fixes OVMF firmware detection on Debian/Ubuntu derivatives.
Add a hidden
bcvk libvirt print-firmwarewhich is a cheap way to test our parser.Assisted-by: Claude Code (Sonnet 4.5)