Make CNCF logo relative to site root #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where the CNCF logo was not displaying on nested pages by changing the image path to be root-relative. The changes are applied to both the main and theme templates. I've added a couple of suggestions to use the get_url template function, which is a more robust and idiomatic way to handle asset URLs in this context, ensuring they work correctly even when the site is deployed in a subdirectory.
Previously with it being page-relative, the logo would render on the main page at '/' but would not work for nested pages such as '/about/'. I've updated both the "main" template and the juice template, although it appears that only the juice template is actually used by the site. Signed-off-by: John Eckersberg <jeckersb@redhat.com>
jeckersb
force-pushed
the
cncf-logo-path
branch
from
65f29ea to
fca7388
Compare
cgwalters
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously with it being page-relative, the logo would render on the
main page at '/' but would not work for nested pages such as
'/about/'.
I've updated both the "main" template and the juice template, although
it appears that only the juice template is actually used by the site.
Signed-off-by: John Eckersberg jeckersb@redhat.com