build-sys: Work around #1546 #1547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a temporary workaround to address an issue with the base image by removing the /root/buildinfo directory before running container lints. The change is straightforward and seems correct for its purpose. I have one suggestion to improve the comment to make it easier to track and remove this workaround in the future.
While we work to fix the base image (again). Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
workaround-buildinfo
branch
from
ded6023 to
926dec1
Compare
jeckersb
approved these changes
Aug 25, 2025
|
re: c10s aarch64 failure - #1544 (comment) 🤔 |
The previous locking code was just wrong; my bad for not stress testing it. Fix it an add a test too. Signed-off-by: Colin Walters <walters@verbum.org>
|
Since we now have two different things breaking our CI, I've rolled a fix for the locking into this PR. |
cgwalters
commented
Aug 25, 2025
| async_task_with_spinner("Waiting for sysroot lock...", sysroot.lock_future()).await?; | ||
| let sysroot_clone = sysroot.clone(); | ||
| let locker = tokio::task::spawn_blocking(move || sysroot_clone.lock()); | ||
| async_task_with_spinner("Waiting for sysroot lock...", locker).await??; |
There was a problem hiding this comment.
This does for me basically always cause a flicker of "Waiting for sysroot lock..." on a terminal, but if someone cares we can change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we work to fix the base image (again).
Closes: #1544