Skip to content

Conversation

@HuijingHei
Copy link
Contributor

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the versions of the bootc-internal-blockdev and bootc-internal-utils crates to 0.1.0. However, there is a critical issue. The dependency on bootc-internal-utils within crates/blockdev/Cargo.toml has not been updated to match the new version, which will cause a build failure. Please see the specific comment for details on how to resolve this.

@HuijingHei HuijingHei mentioned this pull request Dec 8, 2025
Signed-off-by: Huijing Hei <hhei@redhat.com>
@HuijingHei
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly bumps the version of the bootc-internal-blockdev crate to 0.1.0 across the relevant Cargo.toml and Cargo.lock files, presumably for publishing. My review includes one high-severity comment pointing out a dependency issue that will likely block publishing this crate to crates.io.

Signed-off-by: Huijing Hei <hhei@redhat.com>
@github-actions github-actions bot added area/system-reinstall-bootc Issues related to system-reinstall-botoc area/ostree Issues related to ostree labels Dec 9, 2025
@HuijingHei
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the versions of the bootc-internal-blockdev and bootc-internal-utils crates from 0.0.0 to 0.1.0. All dependent crates have been updated to use these new versions, and the Cargo.lock file has been updated accordingly. The changes are consistent and correct for a version bump.

@cgwalters cgwalters merged commit 64eef42 into bootc-dev:main Dec 9, 2025
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ostree Issues related to ostree area/system-reinstall-bootc Issues related to system-reinstall-botoc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants