-
Notifications
You must be signed in to change notification settings - Fork 154
crates/blockdev: publish new version 0.1.0
#1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b68ac1f to
76e9fba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the versions of the bootc-internal-blockdev and bootc-internal-utils crates to 0.1.0. However, there is a critical issue. The dependency on bootc-internal-utils within crates/blockdev/Cargo.toml has not been updated to match the new version, which will cause a build failure. Please see the specific comment for details on how to resolve this.
Signed-off-by: Huijing Hei <hhei@redhat.com>
76e9fba to
f26e7fb
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps the version of the bootc-internal-blockdev crate to 0.1.0 across the relevant Cargo.toml and Cargo.lock files, presumably for publishing. My review includes one high-severity comment pointing out a dependency issue that will likely block publishing this crate to crates.io.
Signed-off-by: Huijing Hei <hhei@redhat.com>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the versions of the bootc-internal-blockdev and bootc-internal-utils crates from 0.0.0 to 0.1.0. All dependent crates have been updated to use these new versions, and the Cargo.lock file has been updated accordingly. The changes are consistent and correct for a version bump.
No description provided.