ostree-ext: Make new packing if using prior build fails #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some circumstances--for example, if a new exclusive component has been added since the prior build--packing with a prior build structure can fail. When this happens, we can simply discard the prior build data and make a new packing structure, rather than having chunking fail entirely.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the robustness of the chunking process by handling failures when reusing a prior build's packing structure. Instead of panicking, it now gracefully falls back to creating a new packing structure. The changes include replacing panic! with bail! for recoverable errors and wrapping the call to basic_packing_with_prior_build in a match to handle the error case. This is a solid improvement. I've added one suggestion to further improve robustness by replacing an assert! with a check that returns a Result, which is in line with the goals of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances—for example, if a new exclusive component has been added since the prior build—packing with a prior build structure can fail. When this happens, we can simply discard the prior build data and make a new packing structure, rather than having chunking fail entirely.
This should fix coreos/rpm-ostree#5545, and I think it'll also fix the test failure that was observed in CI for coreos/rpm-ostree#5535.