fix: use hashing_tag instead of tag so BSL metadata contributes to co…#209
Open
hussainsultan wants to merge 2 commits intomainfrom
Open
fix: use hashing_tag instead of tag so BSL metadata contributes to co…#209hussainsultan wants to merge 2 commits intomainfrom
hussainsultan wants to merge 2 commits intomainfrom
Conversation
…ntent hash Previously, .tag() produced Tag nodes that xorq strips before hashing, meaning two models with different measures/dimensions on the same table would hash identically. Switching to .hashing_tag() (HashingTag) ensures the serialized BSL metadata is included in the content hash. Adds tests verifying different measures produce different hashes and identical models produce the same hash. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ntent hash
Previously, .tag() produced Tag nodes that xorq strips before hashing, meaning two models with different measures/dimensions on the same table would hash identically. Switching to .hashing_tag() (HashingTag) ensures the serialized BSL metadata is included in the content hash.
Adds tests verifying different measures produce different hashes and identical models produce the same hash.