Conversation
DKreuter
commented
Dec 17, 2024
- added hidden physics approach
- @nheilenkoetter: could you please check the new functionality? Do they fit the general idea of model implementation?
- @johannes-mueller : Could you double check the added test? Thanks 🙏
Hidden physics files, merged for checking unit tests
Signed-off-by: Daniel Kreuter <DanielChristopher.Kreuter@de.bosch.com> # Conflicts: # src/torchphysics/problem/conditions/__init__.py # src/torchphysics/problem/conditions/condition.py # tests/test_conditions.py
set matplotlib version to <3.10
Signed-off-by: Daniel Kreuter <DanielChristopher.Kreuter@de.bosch.com>
|
Hi, @DKreuter thank you for creating the PR. There are two comments from my side:
I hope this helps :) |
|
I've now found some time to take a closer look on the implemented Conditions: For the I don't see the use case for the `class ResidualCondition(Condition): |
|
@birupakshapal2017 : Could you please check the comments from @nheilenkoetter . From my point of you we should integrate the proposed general condition approach. Please rewrite and your code. |
|
boschresearch/torchphysics/examples/pinn/data/heat-eq-inverse-data.npy,Could you please explain the composition of the data? I'm not quite clear about your data. |
|
数据形状: torch.Size([30000, 4]) |
|
thank you very much |
@Kangyukuan the data is of the shape (time, space_x, space_y, temperature), randomly selected from the results of FEM. Please open next time a new issue. |