This repository was archived by the owner on Jul 26, 2025. It is now read-only.
Draft
Conversation
github-actions
bot
added
dependencies
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
features/auth/logic/src/main/kotlin/com/nasdroid/auth/logic/auth/LogIn.kt
Fixed
Show fixed
Hide fixed
… polymorphic deserialization in `DdpWebsocketClient`.
# Conflicts: # core/api/src/commonMain/kotlin/com/nasdroid/api/websocket/ddp/EjsonSerializers.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/websocket/ddp/SubscriptionEvent.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/websocket/ddp/Throwables.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/websocket/ddp/message/ConnectionMessages.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/websocket/ddp/message/Error.kt
# Conflicts: # apitester/build.gradle.kts # apitester/src/androidMain/AndroidManifest.xml # apitester/src/androidMain/res/mipmap-anydpi-v26/ic_launcher.xml # gradle/libs.versions.toml
github-actions
bot
removed
the
dependencies
features/auth/logic/src/main/kotlin/com/nasdroid/auth/logic/auth/LogIn.kt
Fixed
Show fixed
Hide fixed
# Conflicts: # app/src/main/java/com/nasdroid/DI.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/DI.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/v2/HttpClient.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/v2/core/CoreV2Api.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/v2/pool/PoolV2Api.kt # core/api/src/commonMain/kotlin/com/nasdroid/api/v2/system/SystemV2Api.kt # features/auth/logic/src/main/kotlin/com/nasdroid/auth/logic/auth/LogIn.kt # features/dashboard/logic/src/test/kotlin/com/nasdroid/dashboard/logic/dataloading/cpu/GetCpuSpecsTest.kt # features/dashboard/logic/src/test/kotlin/com/nasdroid/dashboard/logic/dataloading/memory/GetMemorySpecsTest.kt # features/dashboard/logic/src/test/kotlin/com/nasdroid/dashboard/logic/dataloading/system/GetSystemInformationTest.kt
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The websocket client is now functional! There's likely still some bugs (I'm new to WS in general), and I'm still in the process of migrating everything off REST
Fixes #484