-
Notifications
You must be signed in to change notification settings - Fork 53
Add hwloc to core kit
#672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
^ Updated to no longer include hwloc in |
bcressey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't have use cases in mind for the tools, I'd prefer to invert the packaging and have libhwloc, libhwloc-devel, and libhwloc-tools - so that the tools are optional when the shared library is needed.
Compare to libcrypto-tools and libcryptsetup-tools.
hwloc is needed both as a binary dependency like hwloc-ls but also can be used as a build dependency so this package vends a devel both a tools package and a development package. Signed-off-by: Matthew Yeazel <yeazelm@amazon.com>
|
I rebased the changes and pushed an updated version that provides the shared object and three packages: |
Issue number:
Closes # #670
Description of changes:
Adds
hwlocas package to the core kit. Also vend a devel package in case variants want to bind against hwloc as a build dependency rather than use the binaries.Testing done:
Built images with the binaries included.
hwloc-lsis usable fromsheltie:Built an image and confirmed hwloc-ls will work from a container.
Specfile:
Output:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.