Skip to content

Conversation

@sam-berning
Copy link
Contributor

Issue number:

Closes #

Description of changes:

Patches ecr-credential-provider in order to support a new AWS partition.

Testing done:

Built ecr-credential-provider with the patches, and confirmed I could get credentials for a registry in the new partition:

echo '{"kind":"CredentialProviderRequest","apiVersion":"credentialprovider.kubelet.k8s.io/v1","image":"123456789012.dkr.ecr.eusc-de-east-1.amazonaws.eu"}' | ./ecr-credential-provider

Also built the core-kit and an AMI, and confirmed the same worked on the instance.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@vigh-m
Copy link
Contributor

vigh-m commented Nov 8, 2025

Please add a Signed-off-by tag to all your patches. Example

Signed-off-by: Sam Berning <bernings@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants