Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions daemon/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -1028,6 +1028,9 @@ func (daemon *Daemon) Checkpoint(c *container.Container, opts *types.CriuConfig)
func (daemon *Daemon) Restore(c *container.Container, pipes *execdriver.Pipes, restoreCallback execdriver.DriverCallback, opts *types.CriuConfig, forceRestore bool) (execdriver.ExitStatus, error) {
hooks := execdriver.Hooks{
Restore: restoreCallback,
PostRestore: func(processConfig *execdriver.ProcessConfig, pid int, chOOM <-chan struct{}) error {
return daemon.setNetworkNamespaceKey(c.ID, pid)
},
}

exitCode, err := daemon.execDriver.Restore(c.Command, pipes, hooks, opts, forceRestore)
Expand Down
1 change: 1 addition & 0 deletions daemon/execdriver/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ type Hooks struct {
PostStop []DriverCallback
// Restore is called after the container is restored
Restore DriverCallback
PostRestore DriverCallback
}

// Info is driver specific information based on
Expand Down
13 changes: 13 additions & 0 deletions daemon/execdriver/native/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,20 @@ func (d *Driver) Restore(c *execdriver.Command, pipes *execdriver.Pipes, hooks e
return execdriver.ExitStatus{ExitCode: -1}, err
}

if err := d.createNetwork(&config, c, hooks); err != nil {
return execdriver.ExitStatus{ExitCode: -1}, err
}

oom := notifyOnOOM(cont)
if hooks.PostRestore != nil {
pid, err := p.Pid()
if err != nil {
p.Signal(os.Kill)
p.Wait()
return execdriver.ExitStatus{ExitCode: -1}, err
}
hooks.PostRestore(&c.ProcessConfig, pid, oom)
}
if hooks.Restore != nil {
pid, err := p.Pid()
if err != nil {
Expand Down
12 changes: 12 additions & 0 deletions vendor/src/github.com/vishvananda/netlink/link_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,18 @@ func LinkSetName(link Link, name string) error {
req.AddData(data)

_, err := req.Execute(syscall.NETLINK_ROUTE, 0)
if err != nil && os.IsExist(err) && name == "eth0" {
// XXX Temporary hack.
// If we are called after a container has been restored,
// we need to delete eth0 and try again.
// The right solution is to tell CRIU not create network
// devices.
l := &Device{LinkAttrs: LinkAttrs{Name: name}}
if e := LinkDel(l); e != nil {
return e
}
_, err = req.Execute(syscall.NETLINK_ROUTE, 0)
}
return err
}

Expand Down