Implement Windows Support #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be ready in `run_db`
duosii
changed the title
Author
|
Have you had the chance to review this pull request yet? Or is Windows support something you don't want to add to I could close this PR if that is your wish. |
Owner
|
Hi, I was really busy in august and must have missed this entirely, sorry about that. I have two reservations:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous PR
I have implemented Windows support by making the following changes:
pg_ctlto start and stop the PostgreSQL server on Windows.For the time being, I have disabled the
test_tempdb_bin_pathandtest_slow_postgres_startuptests on Windows due to their reliance upon bash scripts.I have also removed the Python unit test as I was unable to get this working on Windows.