Sort currencies by name and exchange rate for better change generation#5
Open
posadist-revolution wants to merge 1 commit intoboxfriend:masterfrom
Open
Sort currencies by name and exchange rate for better change generation#5posadist-revolution wants to merge 1 commit intoboxfriend:masterfrom
posadist-revolution wants to merge 1 commit intoboxfriend:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that using the unsorted list of currencies made it so that the change returned from buying items from merchants was very strangely formatted and unpleasant (often giving a ton of emerald and heliodor chips instead of larger denominations, if I remember correctly.) This change sorts currencies alphabetically (mainly to make sure that diamond marks are always returned for single-mark values) and then sorts them by value, highest to lowest (to return the smallest possible number of spheres by going for high-value spheres first.)