fix: use asar-safe recursive copy for container assets#13
Merged
DorianZheng merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
Electron's asar shim patches fs.cpSync but the override only handles
single-file extraction via archive.copyFileOut(). When cpSync is called
on a directory with { recursive: true }, copyFileOut returns null and
throws NOT_FOUND. This breaks skills and agent-runner copying when
agentlite is consumed inside an Electron app (.asar archive).
Add copyDirRecursive() in src/utils.ts that tries fs.cpSync first
(fast path for non-asar), then falls back to per-file walk using
readdirSync/statSync/readFileSync/writeFileSync (all properly
asar-patched for individual files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.cpSyncbut the genericoverrideAPISyncwrapper only handles single-file extraction viaarchive.copyFileOut()— it returnsnullfor directories, throwingNOT_FOUND.asararchivecopyDirRecursive()insrc/utils.tsthat triesfs.cpSyncfirst (fast native path), then falls back to per-filereadFileSync/writeFileSyncwalk (all properly asar-patched for individual files)Test plan
npm run buildpassesnpm run dev— send a test message, confirm container/skills and agent-runner are copied without ENOENT