-
Notifications
You must be signed in to change notification settings - Fork 21
Turn into ESM only module #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can be consumed from CJS in Node >= 20.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request converts moddle-xml from a dual CommonJS/ESM module to an ESM-only module, updates dependencies to their latest versions, and modernizes the build configuration and CI workflow.
Changes:
- Converted to ESM-only module by removing CommonJS distribution
- Updated dependencies: min-dash@5, saxen@11.0.2, chai@6, mocha@11, eslint@9, and other dev dependencies
- Modified rollup configuration to output only ESM format and use ESM import syntax
- Updated CI workflow to use Node 24 and newer GitHub Actions versions
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated build script with --bundleConfigAsCjs flag, simplified exports to single ESM entry point, and bumped all dependencies to latest versions |
| rollup.config.js | Converted to ESM syntax using import statement, removed CommonJS output configuration |
| test/integration/distro.cjs | Added ESM import test and simplified to use direct package imports |
| test/expect.js | Changed to use named import from chai instead of default import |
| CHANGELOG.md | Documented v12.0.0 breaking changes and dependency updates |
| .github/workflows/CI.yml | Updated to Node 24 and newer GitHub Actions versions |
| package-lock.json | Updated with new dependency versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Proposed Changes
Node >= 20.12in CommonJS moduleschai@6min-dash@5saxen@11.0.2Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool