Skip to content

Conversation

@nikku
Copy link
Member

@nikku nikku commented Jan 15, 2026

Proposed Changes

  • Housekeeping (DEPS bumps)
  • Turn into ES only module
  • Consume from Node >= 20.12 in CommonJS modules
  • Migrate to chai@6
  • Update to min-dash@5
  • Update to saxen@11.0.2

Checklist

Ensure you provide everything we need to review your contribution:

  • Contribution meets our definition of done
  • Pull request establishes context
    • Link to related issue(s), i.e. Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}
    • Brief textual description of the changes
    • Screenshots or short videos showing UI/UX changes
    • Steps to try out, i.e. using the @bpmn-io/sr tool

Copilot AI review requested due to automatic review settings January 15, 2026 21:38
@nikku nikku added the dependencies Updates a dependency label Jan 15, 2026
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 15, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request converts moddle-xml from a dual CommonJS/ESM module to an ESM-only module, updates dependencies to their latest versions, and modernizes the build configuration and CI workflow.

Changes:

  • Converted to ESM-only module by removing CommonJS distribution
  • Updated dependencies: min-dash@5, saxen@11.0.2, chai@6, mocha@11, eslint@9, and other dev dependencies
  • Modified rollup configuration to output only ESM format and use ESM import syntax
  • Updated CI workflow to use Node 24 and newer GitHub Actions versions

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updated build script with --bundleConfigAsCjs flag, simplified exports to single ESM entry point, and bumped all dependencies to latest versions
rollup.config.js Converted to ESM syntax using import statement, removed CommonJS output configuration
test/integration/distro.cjs Added ESM import test and simplified to use direct package imports
test/expect.js Changed to use named import from chai instead of default import
CHANGELOG.md Documented v12.0.0 breaking changes and dependency updates
.github/workflows/CI.yml Updated to Node 24 and newer GitHub Actions versions
package-lock.json Updated with new dependency versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@barmac barmac merged commit f5934ac into main Jan 16, 2026
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 16, 2026
@barmac barmac deleted the esm-only branch January 16, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Updates a dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants