Define a stable automatic module name. #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@brunchboy would like to modularize the project https://github.com/Deep-Symmetry/lib-carabiner but is unable to do so because edn-java does not define an automatic module name. See http://branchandbound.net/blog/java/2017/12/automatic-module-name/ for details on why this is necessary. All the other lib-carabiner dependencies already do this, so as soon as edn-java does so, it will be possible. This pull request sets `us.bpsm.edn` as the automatic module name, which makes sense as it is likely the module name you will use if you ever decide to modularize this project itself. Thanks for considering this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brunchboy would like to modularize the project lib-carabiner but is unable to do so because edn-java does not define an automatic module name. See this article for a very good explanation of why this is necessary. All the other
lib-carabinerdependencies already do this, so as soon as edn-java does, it will be possible.This pull request sets
us.bpsm.ednas the automatic module name, which makes sense as it is likely the module name you will use if you ever decide to modularize this project itself.Thanks for considering this change.