std::memcpy -> memcpy#101
Open
socram8888 wants to merge 1 commit intobrad-lin:masterfrom
Open
Conversation
|
Duplicate of #97 |
|
Actually I don't know what's better. I initially did the same thing for my pull request but then realized I could just add #include cstring to fix it and settled on that. |
Contributor
Author
|
Not sure. There's only one std::memcpy and plenty of regular memcpy in that file, so I guessed this one was a mistake. |
| // This cheap fix makes it possible to use fake memory cards with a 512 kbits (64 kB) chip. | ||
| if (payloadOffset + payload.size() <= out.size() / 2) { | ||
| std::memcpy(out.data() + out.size() / 2, out.data(), out.size() / 2); | ||
| memcpy(out.data() + out.size() / 2, out.data(), out.size() / 2); |
There was a problem hiding this comment.
maybe:
const size_t half_size = out.size() >> 1;
memcpy(out.data() + half_size, out.data(), half_size);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current code is causing compilation errors in Debian bookworm. Replacing
std::memcpywith justmemcpy(as the rest of the memcpy calls are) fixed the issue.