Claude/remove unused import kfb wa#684
Merged
braedonsaunders merged 2 commits intoclaude/build-openstudio-app-kgia5from Jan 3, 2026
Merged
Claude/remove unused import kfb wa#684braedonsaunders merged 2 commits intoclaude/build-openstudio-app-kgia5from
braedonsaunders merged 2 commits intoclaude/build-openstudio-app-kgia5from
Conversation
The LocalSet approach with spawn_local was causing the WebSocket server to be starved because the TUI uses blocking I/O (crossterm::event::poll) that doesn't yield to the async runtime. Now the WebSocket server runs in a native thread with its own tokio runtime, which: - Avoids Send requirements (AppState contains non-Send cpal::Stream) - Prevents TUI blocking I/O from starving the server - Follows the same pattern as AudioNetworkBridge
Two fixes: 1. Filter key repeats: Only handle KeyEventKind::Press events, ignoring repeats and releases. This prevents rapid toggling when holding a key. 2. Direct panel switching: Changed from toggle functions to direct set_panel() calls. Now A/E/N/L keys always go to the specific panel instead of toggling back and forth.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
braedonsaunders
merged commit 3d2a97b
into
claude/build-openstudio-app-kgia5
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.