Claude/remove unused import kfb wa#698
Merged
braedonsaunders merged 2 commits intoclaude/build-openstudio-app-kgia5from Jan 3, 2026
Merged
Claude/remove unused import kfb wa#698braedonsaunders merged 2 commits intoclaude/build-openstudio-app-kgia5from
braedonsaunders merged 2 commits intoclaude/build-openstudio-app-kgia5from
Conversation
…startup 1. Join as Performer button: - Now only requires bridge connection, not audio running - Audio starts AFTER joining, not before - Removed confusing auto-proceed behavior 2. Effects fixes: - Added #[serde(default)] to ALL effects in EffectsSettings - Fixes deserialization when frontend sends partial effects - Added effects chain processing to monitoring path (was DRY, now WET) - Added logging for updateEffects to help debug 3. Startup sync: - Send initial effects to native bridge on audio start - Send pan value with track state on startup - Log which effects are enabled for debugging
Empty buffer on reconnect is normal - only warn about actual buffer overflow (samples being dropped), not empty buffer conditions.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
braedonsaunders
merged commit bdaf573
into
claude/build-openstudio-app-kgia5
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.