fix(effects): Add serde defaults and aliases for robust message parsing#701
Merged
braedonsaunders merged 1 commit intoclaude/build-openstudio-app-kgia5from Jan 3, 2026
Conversation
Owner
braedonsaunders
commented
Jan 3, 2026
braedonsaunders
commented
- Add #[serde(default)] to all effect struct fields to prevent parse errors when frontend sends partial data
- Add serde aliases for field name mismatches between TS and Rust:
- EqBand: alias "type" for "bandType"
- WahSettings: alias "q" for "resonance"
- Distortion/Amp/Cabinet/Delay/Reverb: alias "type" for respective type fields
- Bitcrusher: alias "bits" for "bitDepth"
- Add Default derive to all effect enum types
- Use forceSetChannelConfig on startup to ensure mono config is always sent to native bridge (fixes mono tracks being panned on load)
- Add debug logging for channel config and pan values on startup
- Add #[serde(default)] to all effect struct fields to prevent parse errors when frontend sends partial data - Add serde aliases for field name mismatches between TS and Rust: - EqBand: alias "type" for "bandType" - WahSettings: alias "q" for "resonance" - Distortion/Amp/Cabinet/Delay/Reverb: alias "type" for respective type fields - Bitcrusher: alias "bits" for "bitDepth" - Add Default derive to all effect enum types - Use forceSetChannelConfig on startup to ensure mono config is always sent to native bridge (fixes mono tracks being panned on load) - Add debug logging for channel config and pan values on startup
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
braedonsaunders
merged commit b9688ac
into
claude/build-openstudio-app-kgia5
2 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.