Add callable microsaccades as intended by #492 #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist/brain-score into callable_microsaccades
benlonnqvist
commented
Jun 17, 2024
benlonnqvist
commented
Jun 17, 2024
benlonnqvist
commented
Jun 17, 2024
mschrimpf
approved these changes
Jun 20, 2024
Member
mschrimpf
left a comment
mschrimpf
left a comment
There was a problem hiding this comment.
looks good once you address suggestions
brainscore_vision/model_helpers/brain_transformation/behavior.py
Outdated
Show resolved
Hide resolved
brainscore_vision/model_helpers/brain_transformation/__init__.py
Outdated
Show resolved
Hide resolved
brainscore_vision/model_helpers/brain_transformation/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com>
…rbiters (required since the generic look_at no longer takes kwargs but specifically require_variance)
Contributor
Author
|
@mschrimpf Looks like it's all green now - should be good to merge |
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #492 added microsaccades to brain-score but unintendedly, were only accessible by directly accessing the
activations_model._extractor. This PR extends the microsaccades to be callable from themodel.look_at()method (for testing stimuli) andmodel.start_task()method (for fitting stimuli), as intended by the description of PR #492.In short, this PR simply extends the call signature of
require_varianceandnumber_of_trialsa bit further than before.PR #365 depends on this PR.