Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions promptlens/loaders/json_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ def load(self, path: str) -> GoldenSet:
except json.JSONDecodeError as e:
raise ValueError(f"Invalid JSON in {path}: {e}")

if not isinstance(data, dict):
raise ValueError(
f"Invalid golden set format in {path}: root value must be a JSON object"
)

try:
golden_set = GoldenSet(**data)
logger.info(
Expand Down
5 changes: 5 additions & 0 deletions promptlens/loaders/yaml_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ def load(self, path: str) -> GoldenSet:
if data is None:
raise ValueError(f"Empty YAML file: {path}")

if not isinstance(data, dict):
raise ValueError(
f"Invalid golden set format in {path}: root value must be a YAML mapping"
)

try:
golden_set = GoldenSet(**data)
logger.info(
Expand Down
22 changes: 22 additions & 0 deletions tests/test_loader_root_validation.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import json

import pytest

from promptlens.loaders.json_loader import JSONLoader
from promptlens.loaders.yaml_loader import YAMLLoader


def test_json_loader_rejects_non_object_root(tmp_path):
p = tmp_path / "golden.json"
p.write_text(json.dumps([{"id": "tc-1"}]), encoding="utf-8")

with pytest.raises(ValueError, match="root value must be a JSON object"):
JSONLoader().load(str(p))


def test_yaml_loader_rejects_non_mapping_root(tmp_path):
p = tmp_path / "golden.yaml"
p.write_text("- id: tc-1\n", encoding="utf-8")

with pytest.raises(ValueError, match="root value must be a YAML mapping"):
YAMLLoader().load(str(p))