feat: nightly hardening - http provider endpoint normalization#11
Open
mouse-value-add wants to merge 1 commit intobrainsparker:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
The
httpprovider path was brittle and effectively misconfigured in common usage.HTTPProviderrequiresProviderConfig.endpoint, butget_provider()did not map endpoint fromModelConfig.additional_params, which meant the provider could fail to initialize or leak config-only keys into request payloads.This weakens a foundational capability, local model evaluation, and creates avoidable runtime failures.
approach
endpointandtimeoutfields toModelConfig.get_provider():additional_paramsvia a copy (no input mutation).httpprovider, accept legacyadditional_params.endpointas a backwards-compatible fallback.endpointfromadditional_paramsso it is not sent to inference APIs.endpointandtimeoutintoProviderConfig.endpointwhile preserving backward compatibility in code.verification
python3 -m pytest -qtests/test_provider_factory_hardening.pyrisks
additional_params.endpoint.ModelConfig.timeout,ModelConfig.endpoint) may affect strict external schema consumers, but defaults preserve prior behavior.rollback plan
091636b.ModelConfigschema and provider factory mapping behavior.