Skip to content

refactor: nightly hardening - pydantic config migration #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mouse-value-add wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: nightly hardening - pydantic config migration #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions promptlens/models/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from typing import Any, Dict, List, Optional

from pydantic import BaseModel, Field
from pydantic import BaseModel, ConfigDict, Field


class ProviderConfig(BaseModel):
Expand Down Expand Up @@ -114,9 +114,8 @@ class RunConfig(BaseModel):
execution: ExecutionConfig = Field(default_factory=ExecutionConfig)
output: OutputConfig = Field(default_factory=OutputConfig)

class Config:
"""Pydantic config."""
json_schema_extra = {
model_config = ConfigDict(
json_schema_extra={
"example": {
"golden_set": "./examples/golden_sets/customer_support.yaml",
"models": [
Expand All @@ -143,3 +142,4 @@ class Config:
},
}
}
)
14 changes: 7 additions & 7 deletions promptlens/models/test_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from typing import Any, Dict, List, Optional

from pydantic import BaseModel, Field
from pydantic import BaseModel, ConfigDict, Field

from promptlens.models.tools import ToolDefinition, ExpectedToolCall

Expand Down Expand Up @@ -50,9 +50,8 @@ class TestCase(BaseModel):
description="Whether to actually execute tools (default: False, evaluation only)"
)

class Config:
"""Pydantic config."""
json_schema_extra = {
model_config = ConfigDict(
json_schema_extra={
"example": {
"id": "cs-001",
"query": "How do I reset my password?",
Expand All @@ -61,6 +60,7 @@ class Config:
"tags": ["password", "account"],
}
}
)


class GoldenSet(BaseModel):
Expand All @@ -80,9 +80,8 @@ class GoldenSet(BaseModel):
test_cases: List[TestCase]
metadata: Dict[str, Any] = Field(default_factory=dict)

class Config:
"""Pydantic config."""
json_schema_extra = {
model_config = ConfigDict(
json_schema_extra={
"example": {
"name": "Customer Support Tests",
"description": "Test cases for customer support chatbot",
Expand All @@ -98,3 +97,4 @@ class Config:
],
}
}
)
5 changes: 2 additions & 3 deletions promptlens/models/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"""

from typing import Any, Dict, List, Optional
from pydantic import BaseModel, Field
from pydantic import BaseModel, ConfigDict, Field


class ToolParameter(BaseModel):
Expand All @@ -24,8 +24,7 @@ class ToolParameter(BaseModel):
properties: Optional[Dict[str, "ToolParameter"]] = Field(None, description="For object types, nested properties")
items: Optional["ToolParameter"] = Field(None, description="For array types, the item schema")

class Config:
extra = "allow" # Allow additional JSON Schema fields
model_config = ConfigDict(extra="allow") # Allow additional JSON Schema fields


class ToolDefinition(BaseModel):
Expand Down