fix: nightly hardening - yaml unsafe key guard#9
Open
mouse-value-add wants to merge 1 commit intomainfrom
Open
fix: nightly hardening - yaml unsafe key guard#9mouse-value-add wants to merge 1 commit intomainfrom
mouse-value-add wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
The YAML frontmatter parser accepted reserved JavaScript object keys like
__proto__,constructor, andprototype. In JavaScript, writing these keys can mutate object prototypes or introduce confusing object behavior, which weakens parser safety when untrusted profile content is loaded.approach
__proto__,constructor,prototype) at parse time.{key: value}).verification
npm test -- --run test/parser/yaml.test.tsnpm testrisks
rollback plan
4a11163to restore prior parser behavior.src/parser/yaml.tsand corresponding tests intest/parser/yaml.test.ts.