Refactored code for use as a library.#23
Open
frobnitzem wants to merge 2 commits intobramstein:masterfrom
Open
Refactored code for use as a library.#23frobnitzem wants to merge 2 commits intobramstein:masterfrom
frobnitzem wants to merge 2 commits intobramstein:masterfrom
Conversation
|
Do your changes have any effects on reported bugs?
|
|
I haven't reviewed these in detail @PhilterPaper, but the typical definition of "refactoring" code in programmer jargon would mean that no, this has no affect on reported bugs. When you refactor code you basically shuffle things around to different places or making various structural changes to the code, but the expected input and output is the same. Of course refactoring can fix bugs (or introduce new ones), but the goal of a refactor is to not change the function while improving the code health. |
Author
|
These are maintainability improvements, so that changes to the codebase can be more isolated and require less working memory for library developers and users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main files were moved into the src directory, and Typeset was removed
in favor of the classes "LineBreak," "LinkedList," and the function "BreakLines."
It seems that LinkedList could be written to use arrays...
Top-level wrapper functions from browser-assist were moved into
src/typeset.jswhich is now called like:ideally, the more advanced ones used in flatland will follow later.